[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] server makefiles should respect LDFLAGS



Hi Raman,

I too can confirm no problems with greader under emacs 24 and it all compiles
fine. There are a number of warnings regarding free variables and some warnings
regarding possibly undefined functions, but it builds fine. 

Looking at the patch, all it seems to do is remove the spurious character 'e'
after the closing brace for the defvar. This character looks like a simple typo
and should be removed, so applying the patch should be fine. However, I too
cannot see any reason this patch was required in order to build the g-client
code.

Tim


T.V. Raman writes:
 > Not sure why this patch is needed for emacs 24, emacs 24 is what
 > I'm using, and I haven't needed it. It looked benign enough, but
 > I'd like an explanation as to what he thought was broken in emacs 2.
 > --- emacspeak-33.0-orig/lisp/g-client/greader.el
 > +++ emacspeak-33.0/lisp/g-client/greader.el
 > @@ -704,7 +704,7 @@
 > 
 >  (defvar greader-contents-rest-url
 >    "http://www.google.com/reader/api/0/stream/items/contents";
 > -  "REST endpoint for getting content.")e
 > +  "REST endpoint for getting content.")
 > 
 >  (defun greader-search-results (query)
 >    "Return GReader search results."
 > 
 > -- 
 > Best Regards,
 > --raman
 > 
 > -- 
 > Best Regards,
 > --raman
 > 
 > 
 > On 12/1/10, William Hubbs <w.d.hubbs@gmail.com> wrote:
 > > ---
 > >  servers/linux-espeak/Makefile  |    2 +-
 > >  servers/linux-outloud/Makefile |    4 ++--
 > >  servers/software-dtk/Makefile  |    2 +-
 > >  3 files changed, 4 insertions(+), 4 deletions(-)
 > >
 > > diff --git a/servers/linux-espeak/Makefile b/servers/linux-espeak/Makefile
 > > index 2fd8f66..d247b04 100644
 > > --- a/servers/linux-espeak/Makefile
 > > +++ b/servers/linux-espeak/Makefile
 > > @@ -15,7 +15,7 @@ TTS=tclespeak.so
 > >  all:   $(TTS)
 > >
 > >  $(TTS): tclespeak.o
 > > -	$(CXX) -shared -o $@ $< $(LIBS)
 > > +	$(CXX) $(LDFLAGS) -shared -o $@ $< $(LIBS)
 > >
 > >  clean:
 > >  	rm -f *.so *.o
 > > diff --git a/servers/linux-outloud/Makefile b/servers/linux-outloud/Makefile
 > > index 0e5a061..c6915a8 100644
 > > --- a/servers/linux-outloud/Makefile
 > > +++ b/servers/linux-outloud/Makefile
 > > @@ -15,10 +15,10 @@ LIBS= -ltcl$(TCL_VERSION) -lasound -ldl
 > >  all:   atcleci.so
 > >
 > >  atcleci.so: langswitch.o atcleci.o
 > > -	$(CXX) -m32 -shared -o $@ langswitch.o atcleci.o $(LIBS)
 > > +	$(CXX) $(LDFLAGS) -m32 -shared -o $@ langswitch.o atcleci.o $(LIBS)
 > >
 > >  alsaparams: alsaparams.o
 > > -	$(CC) -o $@ alsaparams.o -lasound
 > > +	$(CC) $(LDFLAGS) -o $@ alsaparams.o -lasound
 > >
 > >  clean:
 > >  	rm -f *.so *.o
 > > diff --git a/servers/software-dtk/Makefile b/servers/software-dtk/Makefile
 > > index 383592e..1b623bd 100644
 > > --- a/servers/software-dtk/Makefile
 > > +++ b/servers/software-dtk/Makefile
 > > @@ -11,7 +11,7 @@
 > > SERVER_DIR=/usr/share/emacs/site-lisp/emacspeak/servers/software-dtk
 > >  FILES=tcldtk.c tcldtk.so tcldtk.o Makefile
 > >
 > >  tcldtk.so: tcldtk.o
 > > -	$(CC) -shared -o $@ $< $(LIBS)
 > > +	$(CC) $(LDFLAGS) -shared -o $@ $< $(LIBS)
 > >
 > >  dist: software-dtk.tar.gz
 > >
 > > --
 > > 1.7.2.2
 > >
 > >
 > 
 > -----------------------------------------------------------------------------
 > To unsubscribe from the emacspeak list or change your address on the
 > emacspeak list send mail to "emacspeak-request@cs.vassar.edu" with a
 > subject of "unsubscribe" or "help".
 > 

-- 
Tim Cross
Information Technology 
University of New England
 Phone: +61 2 6773 3210
Mobile: 0428 212217
   Fax: +61 2 6773 3424
E-Mail: tcross@une.edu.au
   Web: http://www.une.edu.au/itd
---
Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html

Any fool can make things bigger, more complex, and more violent. It takes a
touch of genius (and a lot of courage) to move in the opposite direction.
                                                           âAlbert Einstein






-----------------------------------------------------------------------------
To unsubscribe from the emacspeak list or change your address on the
emacspeak list send mail to "emacspeak-request@cs.vassar.edu" with a
subject of "unsubscribe" or "help".



If you have questions about this archive or had problems using it, please send mail to:

priestdo@cs.vassar.edu No Soliciting!

Emacspeak List Archive | 2010 | 2009 | 2008 | 2007 | 2006 | 2005 | 2004 | 2003 | 2002 | 2001 | 2000 | 1999 | 1998 | Pre 1998

Emacspeak Files | Emacspeak Blog | Search the archive