[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Emacspeak and org mode



Hi Raman,

it seems some of my problems were due to recent org changes, which appear to have been reverted with todays updated org-plus-contrib. However, I am now seeing some other problems. 

I’m a little confused with respect to advice and the chagnes which have been made. Am I right in assuming that emacspeak is still using the older defadvice rather than the suggested advice-add approach?

Also, I think there is something wrong in some of the advice defined for org-mode. In emacspeak-org.el Updated from git today), you have


(loop
 for f in
 '(
   org-occur
   org-beginning-of-line org-end-of-line
   org-beginning-of-item org-beginning-of-item-list)
 do
 (eval
  `(defadvice ,f (around emacspeak pre act comp)
     "Provide auditory feedback."
     (when (ems-interactive-p) (emacspeak-speak-line)))))


as this is an ‘around’ advice, don’t you need to also call ad-do-it to actually execute the underlying function? I notice in org-mode files right now, C-a, which is bound to org-beginning-of-line just speaks the line and does not move the point. I suspect this is an error and you really want after rather than around for this advice?

regards,


Tim




Tim Cross

IT Security Manager
Information Technology Directorate

University of New England
Armidale N.S.W. 2351 Australia

Email: tcross@une.edu.au
Phone: +61 2 6773 3210
Mobile: +61 428 212 217

On 14 Aug 2015, at 1:18 am, raman <raman@google.com> wrote:

Here are some tips on how you can go about chasing down the cause of the
spurious feedback etc.

1. Read the docs for commands ad-activate-advice, ad-enable-advice and
their opposites.

2. Use describe-key to find the command  you're running  when the
problem occurs.

3. See if that command is advised; if yes, then if the issue is too much
feedback, play with ad-deactivate and ad-disable 

4. If it is too little feedback, see if the command is advised, and if
yes, if its output is being clobbered by something else.

5. A good way to check if something else is clobbering the output is to
run one of the logging servers, execute just the problem command
sequence, then study the set of speech calls.
-- 

-----------------------------------------------------------------------------
To unsubscribe from the emacspeak list or change your address on the
emacspeak list send mail to "emacspeak-request@cs.vassar.edu" with a
subject of "unsubscribe" or "help".


Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail



If you have questions about this archive or had problems using it, please send mail to:

priestdo@cs.vassar.edu No Soliciting!

Emacspeak List Archive | 2010 | 2009 | 2008 | 2007 | 2006 | 2005 | 2004 | 2003 | 2002 | 2001 | 2000 | 1999 | 1998 | Pre 1998

Emacspeak Files | Emacspeak Blog | Search the archive