[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: patch for emacspeak-gnus.el
- To: firstname.lastname@example.org, email@example.com
- Subject: Re: patch for emacspeak-gnus.el
- From: "Robert D. Crawford" <firstname.lastname@example.org>
- Date: Sun, 09 Apr 2006 21:25:47 -0500
- Delivered-To: email@example.com
- Delivered-To: firstname.lastname@example.org
- In-Reply-To: <email@example.com> (T. V. Raman'smessage of "Sun, 9 Apr 2006 15:02:30 -0700")
- List-Help: <mailto:firstname.lastname@example.org?subject=help>
- List-Post: <mailto:email@example.com>
- List-Subscribe: <mailto:firstname.lastname@example.org?subject=subscribe>
- List-Unsubscribe: <mailto:email@example.com?subject=unsubscribe>
- Old-Return-Path: <firstname.lastname@example.org>
- References: <email@example.com><firstname.lastname@example.org>
- Resent-Date: Sun, 9 Apr 2006 22:35:03 -0400 (EDT)
- Resent-From: email@example.com
- Resent-Message-ID: <McXCzD.A.QgE.XRcOEB@mail>
- Resent-Sender: firstname.lastname@example.org
- User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.4 (gnu/linux)
"T. V. Raman" <email@example.com> writes:
> I've applied the patch and re-arranged the code to ensure that
> defsubsts occur before they are used.
Thanks for accepting my patches. I feel bad that you are having to make
changes before they are ready to go. I have a question as to how I am
doing things so that we can avoid this in the future.
> in general, before submitting a patch -- ensure that 8all* byte
> compiler warnings are eliminated.
I thought I had done this. Let me give you the steps that I took so
that you can tell me where I mis-stepped.
1. All new code goes into my .emacs file. All code that is changed is
changed in the emacspeak-gnus.el file and I make a note so that I
remember what I changed.
2. I do a cvs update to make sure that I have the latest version.
3. I make a copy of the emacspeak-gnus.el file with an orig extension.
4. In the .el file I make the edits and add my code in the section that
appears to be correct.
5. I then make a diff file and apply the patch to the orig file so that
I can make sure that no errors come up in the patch.
6. I run the make config, and look for an error at the end of the
output. If I see the message that says something like "now run make
emacspeak" I run make emacspeak, again looking for errors at the end
of the output. I think this might be where I am going wrong. Does
the make emacspeak command not choke on errors like other make
7. Now I exit emacs and from the console I run a script that does the
make install and builds the atcleci files, moves the eci.ini file
that I have edited to the correct location, etc.
8. If emacspeak runs after this, I send the patchfile.
As I said, I feel bad that you have to make changes before my patches
will apply and build cleanly. This is work that I should be doing, it
is just that I thought I was doing it correctly. If you can tell me
where I am going wrong, I will do my damnedest to make sure that your
job is made easier, not more difficult, in the future.
> This is a good way to lit your code.
Lit? I do not understand.
Thanks for all your help,
Robert D. Crawford firstname.lastname@example.org
"You have been in Afghanistan, I perceive."
-- Sir Arthur Conan Doyle, "A Study in Scarlet"
To unsubscribe from the emacspeak list or change your address on the
emacspeak list send mail to "email@example.com" with a
subject of "unsubscribe" or "help"
Emacspeak Files |
Unsubscribe | Search