[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch] emacspeak-w3m.el and problems (was: new patches)



"T. V. Raman" <raman@users.sf.net> writes:

> your patches are checked in.

Thanks.

> Unrelated to these patches: emacspeak-w3m.el needs a bunch of cleanup
> --- could you fix the missing declaration of globals -- specifically
> w3m-current-url in many of the google commands?

Here is a patch that I think catches all the undeclared global
variables.  

I have found some other issues with the code.  A few of these I have
known about for some time but they weren't show stoppers so they went to
the back of the queue.

this shows up when tabbing to a submit button.  It only stops things
when debug-on-error is on, otherwise it just doesn't speak the button text.

Debugger entered--Lisp error: (wrong-number-of-arguments #[(form &optional name value) ("/home/rdc/share/emacs/site-lisp/emacspeak/lisp/emacspeak-w3m.elc" . 7082) nil 9 ("/home/rdc/share/emacs/site-lisp/emacspeak/lisp/emacspeak-w3m.elc" . 6981)] 4)
  emacspeak-w3m-speak-form-submit([w3m-form-object get "http://www.google.com/search" nil application/x-www-form-urlencoded (1 (:value ...) 2 (:value ...) 3 (:value ...) 4 (:value ...) 5 (:value ...))] "btnG" "Google Search" w3m-form-new-session)
  apply(emacspeak-w3m-speak-form-submit ([w3m-form-object get "http://www.google.com/search" nil application/x-www-form-urlencoded (1 ... 2 ... 3 ... 4 ... 5 ...)] "btnG" "Google Search" w3m-form-new-session))
  emacspeak-w3m-speak-this-anchor()
  w3m-next-anchor(1)
  call-interactively(w3m-next-anchor)


The transcode functions both work with no args but the
transcode-current-url gives an error.  This seems to be an error in the
url being passed.  I included this  for completeness, as I think I can
track this down but thought I would mention it when sending the patch.

I do not have this function on my system.  
(defadvice w3m-wget (after emacspeak pre act comp)

Since I have toggled debug-on-error I have seen a few other errors, but
they will have to wait until my next mail.

Thanks,
rdc




emacspeak-w3m.el.diff.gz



-- 
Robert D. Crawford                                      rdc1x@comcast.net

I'm totally DESPONDENT over the LIBYAN situation and the price of CHICKEN ...

Emacspeak Files | Subscribe | Unsubscribe | Search