Re: Patch: Allow Emacspeak to work with 8-bit characters

["T. V. Raman" <raman@xxxxxxxxxxx>]

I did not apply it --and do not intend doing so because 
it proliferates badness through the advice.


>>>>> "Milan" == Milan Zamazal <pdm@xxxxxxxxxxx> writes:

>>>>> "MZ" == Milan Zamazal <pdm@xxxxxxxxxxx> writes:
>>>>> "TVR" == T V Raman <raman@xxxxxxxxxxx> writes:

    TVR> I've not added the quail related patches because
    TVR> they spread quail dependencies in a lot of places
    TVR> in the emacspeak-advice module--

    MZ> The quail related thing is not dependent on quail,
    MZ> it works even when quail is not present.  It handles
    MZ> the following problem: When one uses a quail based
    MZ> keyboard, Emacspeak reads not only the character
    MZ> that actually appears in the buffer, but also the
    MZ> English keyboard characters generating it, which is
    MZ> very annoying.  Again, I think you can apply the
    MZ> patch without affecting quail non-users in any way
    MZ> while helping quail users.  Could you please apply
    MZ> it?

    Milan> I can see the patch fixing the Emacspeak
    Milan> inconvenience when using quail keyboard hasn't
    Milan> been applied.  Is there any reason not to apply
    Milan> it?  Here it is again:

    Milan> *** lisp/emacspeak-advice.el Tue Nov 6 11:48:04
    Milan> 2001 --- lisp/emacspeak-advice.el Fri Nov 9
    Milan> 14:00:07 2001 *************** *** 807,821 ****
  
    Milan>   ;;}}} ;;{{{ advice various input functions to
    Milan> speak: (defadvice read-key-sequence(around
    Milan> emacspeak pre act ) "Prompt using speech as
    Milan> well. " !  (let ((prompt (ad-get-arg 0))) !
    Milan> (when prompt (tts-with-punctuations "all" !
    Milan> (dtk-speak prompt))) ad-do-it !
    Milan> (tts-with-punctuations "all" !  (dtk-speak
    Milan> (format "%s" ad-return-value))) ad-return-value))
    Milan> (unless emacspeak-xemacs-p ; we need to advice
    Milan> these only for FSF Emacs --- 807,824 ----
  
    Milan>   ;;}}} ;;{{{ advice various input functions to
    Milan> speak: + (defvar quail-translating nil)
    Milan> (defadvice read-key-sequence(around emacspeak pre
    Milan> act ) "Prompt using speech as well. " !  (let
    Milan> ((prompt (ad-get-arg 0)) !  (in-quail-p
    Milan> quail-translating)) !  (when (and prompt (not
    Milan> in-quail-p)) (tts-with-punctuations "all" !
    Milan> (dtk-speak prompt))) ad-do-it !  (unless
    Milan> in-quail-p !  (tts-with-punctuations "all" !
    Milan> (dtk-speak (format "%s" ad-return-value))))
    Milan> ad-return-value)) (unless emacspeak-xemacs-p ; we
    Milan> need to advice these only for FSF Emacs

    Milan> Thanks,

    Milan> Milan Zamazal

    Milan> -- I think any law that restricts independent use
    Milan> of brainpower is suspect.  -- Kent Pitman in
    Milan> comp.lang.lisp

-- 
Best Regards,
--raman

      
Email:  raman@xxxxxxxxxxx
WWW: http://www.cs.cornell.edu/home/raman/             
PGP:    http://www.cs.cornell.edu/home/raman/raman.asc 

-----------------------------------------------------------------------------
To unsubscribe from the emacspeak list or change your address on the
emacspeak list send mail to "emacspeak-request@xxxxxxxxxxx" with a
subject of "unsubscribe" or "help"